I feel like there's a lot of eye-rolling and doubt regarding Divination in the Harry Potter books from almost everyone in them, especially in regards to Sybill Trelawney. There's a saying that I think a lot of people would feel fits her perfectly: "Even a broken clock is right twice a day."
Now my question to you all is: do you feel, given the information we know of her from the books and from JKR later on, that she was a "broken clock"?
Personally, I feel that Trelawney wasn't as gifted with having prophecies come to her (we only see her have the two in the series) but that she was actually very good at seeing the future in short bursts. For example, with Neville and the broken cup when they did the tea readings in third year and with Umbridge's demise at the end of fifth year. I feel like a lot of doubt came down to her excessive sherry consumption which I think was really just an unhealthy coping mechanism to the outcome of the end of the first war against Voldemort since it was her prophecy that caused the end of it at the cost of the Potters' lives.